Browse Source

Do not use AlphaNum when string contains comma

Using dash in this context will create a range between `+` and `.` which allows the following characters: `+`, `,`, `-`, `.`. 

The ASCII range is as follow: + (43), , (44), - (45), . (46).

Comma is not supported and will then crash in `write()`.
Einar Gangsø 3 months ago
parent
commit
03e84852b4
1 changed files with 1 additions and 1 deletions
  1. 1 1
      src/Data/AlphaNum.php

+ 1 - 1
src/Data/AlphaNum.php

@@ -36,7 +36,7 @@ final class AlphaNum extends QRDataModeAbstract{
 	}
 
 	public static function validateString(string $string):bool{
-		return (bool)preg_match('/^[A-Z\d %$*+-.:\/]+$/', $string);
+		return (bool)preg_match('/^[A-Z\d %$*+\-.:\/]+$/', $string);
 	}
 
 	public function write(BitBuffer $bitBuffer, int $versionNumber):static{