smiley 2 tahun lalu
induk
melakukan
ae0f312415
2 mengubah file dengan 5 tambahan dan 2 penghapusan
  1. 4 1
      src/Data/QRDataModeInterface.php
  2. 1 1
      src/Output/QRMarkupHTML.php

+ 4 - 1
src/Data/QRDataModeInterface.php

@@ -21,10 +21,13 @@ interface QRDataModeInterface{
 	 * the current data mode: Number, Alphanum, Kanji, Hanzi, Byte, ECI
 	 *
 	 * tbh I hate this constant here, but it's part of the interface, so I can't just declare it in the abstract class.
-	 * phan will complain about a PhanAccessOverridesFinalConstant.
+	 * (phan will complain about a PhanAccessOverridesFinalConstant)
+	 *
+	 * @see https://wiki.php.net/rfc/final_class_const
 	 *
 	 * @var int
 	 * @see \chillerlan\QRCode\Common\Mode
+	 * @internal do not call this constant from the interface, but rather from one of the child classes
 	 */
 	public const DATAMODE = -1;
 

+ 1 - 1
src/Output/QRMarkupHTML.php

@@ -42,7 +42,7 @@ class QRMarkupHTML extends QRMarkup{
 		// wrap the snippet into a body when saving to file
 		if($saveToFile){
 			$html = sprintf(
-				'<!DOCTYPE html><html><head><meta charset="UTF-8"><title>QR Code</title></head><body>%s</body></html>',
+				'<!DOCTYPE html><html lang=""><head><meta charset="UTF-8"><title>QR Code</title></head><body>%s</body></html>',
 				$this->options->eol.$html
 			);
 		}